tools: work around collision of -O0 and -D_FORTIFY_SOURCE
authorIan Jackson <ian.jackson@eu.citrix.com>
Thu, 5 Feb 2015 16:28:56 +0000 (16:28 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Fri, 6 Feb 2015 17:26:30 +0000 (17:26 +0000)
commit001324547356af86875fad5003f679571a6b8f1c
tree50212e737d6330a5943a90391006744434036a5b
parent58c030d5f8048a95c485ebf6296066c45bde1cd4
tools: work around collision of -O0 and -D_FORTIFY_SOURCE

Some systems have python-config include -D_FORTIFY_SOURCE in the
CFLAGS.  But -D_FORTIFY_SOURCE does not (currently) work with -O0, and
-O0 is enabled in debug builds (since 1166ecf781).  As a result, on
those systems, debug builds fail.

Work around this problem as follows:
 * In configure, detect -D_FORTIFY_SOURCE in $(python-config --cflags)
 * If detected, set the new autoconf substitution and make variable
   PY_NOOPT_CFLAGS to -O1.
 * In tools/Rules.mk, where we add -O0, also add PY_NOOPT_CFLAGS
   (which will override the -O0 with -O1 if required).

Overriding the -O0 is better than disabling Fortify because the
latter might have an adverse security impact.  A user who wants to
disable optimisation completely even for Python and also disable
Fortify can set the environment variable
    EXTRA_CFLAGS_XEN_TOOLS='-U_FORTIFY_SOURCE -O0'

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reported-by: Jan Beulich <JBeulich@suse.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Euan Harris <euan.harris@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Tested-by: Don Slutz <dslutz@verizon.com>
config/Tools.mk.in
m4/python_fortify_noopt.m4 [new file with mode: 0644]
tools/Rules.mk
tools/configure
tools/configure.ac
tools/pygrub/Makefile
tools/python/Makefile